rmannibucau commented on code in PR #34:
URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051562968


##########
xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java:
##########
@@ -95,14 +96,65 @@ public void testIterator() throws Exception {
             actual.add(entry.getName());
         }
 
-        assertFalse(0 == actual.size());
+        Assert.assertFalse(0 == actual.size());
 
         for (Class clazz : classes) {
-            assertTrue(clazz.getName(), actual.contains(clazz.getName()));
+            Assert.assertTrue(clazz.getName(), 
actual.contains(clazz.getName()));
         }
 
-        assertEquals(classes.length, actual.size());
+        Assert.assertEquals(JarArchiveTest.classes.length, actual.size());
     }
 
+    @Test
+    public void testXBEAN337() throws Exception {

Review Comment:
   Sure - but will likely wait tomorrow.
   Just to be sure: you want I integrate the test as disabled on main branch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to