[
https://issues.apache.org/jira/browse/GIRAPH-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400083#comment-13400083
]
Eli Reisman commented on GIRAPH-213:
------------------------------------
By way of explanation, the patch is a bit goofy looking, but using the
ChannelFuture for completion is apparently the netty.io recommended way to go.
The future event will (apparently) be triggered regardless of the success or
failure of any given close operation, so as soon as everyone is accounted for,
the ClientBootstrap's thread pools (etc) are guaranteed to be released (i.e.
zero chance of bootstrap not releasing due to failed Channel closures, at least
as it is explained on netty.io)
Not an important improvement, just more housekeeping.
> NettyClient.stop() could deadlock according to netty.io docs
> ------------------------------------------------------------
>
> Key: GIRAPH-213
> URL: https://issues.apache.org/jira/browse/GIRAPH-213
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Attachments: GIRAPH-213-1.patch
>
>
> NettyClient.stop() does not follow netty.io best practices and could
> potentially deadlock?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
