[ 
https://issues.apache.org/jira/browse/GIRAPH-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403699#comment-13403699
 ] 

Eli Reisman commented on GIRAPH-213:
------------------------------------

Just rolled back the patches added today since the build is havign trouble with 
BspTestCase and tried this patch again. It compiles and tests with full 'mvn 
verify' so I don't think its the problem. A lot of stuff got committed today.

one issue is some ofthe patches might (probably!) use input or output formats 
that my other patch consolidated under the lib/ directory, this could break 
those patches. Don't know what the protocol is here to fix this. could be 
something else too. I might try to layer on a few more of the ones commmited 
today to see where it dies.

                
> NettyClient.stop() could deadlock according to netty.io docs
> ------------------------------------------------------------
>
>                 Key: GIRAPH-213
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-213
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Eli Reisman
>            Assignee: Eli Reisman
>            Priority: Trivial
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-213-1.patch
>
>
> NettyClient.stop() does not follow netty.io best practices and could 
> potentially deadlock?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to