[
https://issues.apache.org/jira/browse/GIRAPH-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402737#comment-13402737
]
Eli Reisman commented on GIRAPH-213:
------------------------------------
To summarize: even when you need a synchronous barrier event like this, the
netty.io folks recommend the Future method with synch channels like this. I
know it looks odd. Seen stuff like this in "Concurrency in Practice" too. The
current way is deprecated. Big "BAD Don't do this" on the site :)
> NettyClient.stop() could deadlock according to netty.io docs
> ------------------------------------------------------------
>
> Key: GIRAPH-213
> URL: https://issues.apache.org/jira/browse/GIRAPH-213
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Fix For: 0.2.0
>
> Attachments: GIRAPH-213-1.patch
>
>
> NettyClient.stop() does not follow netty.io best practices and could
> potentially deadlock?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
