----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14046/#review26014 -----------------------------------------------------------
Looks good, I like this cleaner semantics of the ZK configuration, compared to != null. - Claudio Martella On Sept. 9, 2013, 11:45 p.m., Armando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14046/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2013, 11:45 p.m.) > > > Review request for giraph. > > > Repository: giraph-git > > > Description > ------- > > This patch is intended to refactor the way zookeeper list is kept in the > configuration. In this manner the list is available also in other classes > different from the services (BspService) which may benefit of zookeeper > functionalities. > > I introduce the change of semantic of this type: > conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal() > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java aae01da > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java > 15ff861 > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java > 604729a > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java > 704fb9e > giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java > 454c934 > giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java > 112b76d > giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnClient.java > 341db0e > > Diff: https://reviews.apache.org/r/14046/diff/ > > > Testing > ------- > > mvn verify with java 6 passed. > > > Thanks, > > Armando > >
