----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14046/ -----------------------------------------------------------
(Updated Sept. 14, 2013, 10:27 p.m.) Review request for giraph. Changes ------- Updating the patch with error messaging when Edge or Vertex Input/Output format are missing. Repository: giraph-git Description ------- This patch is intended to refactor the way zookeeper list is kept in the configuration. In this manner the list is available also in other classes different from the services (BspService) which may benefit of zookeeper functionalities. I introduce the change of semantic of this type: conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal() Diffs (updated) ----- giraph-rexster/src/main/java/org/apache/giraph/rexster/conf/GiraphRexsterConstants.java c4b4655 giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterEdgeInputFormat.java 4dee078 giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterEdgeOutputFormat.java PRE-CREATION giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterVertexInputFormat.java da45b5b giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterVertexOutputFormat.java PRE-CREATION giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongDoubleFloatEdgeOutputFormat.java PRE-CREATION giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongDoubleFloatVertexOutputFormat.java PRE-CREATION giraph-rexster/src/main/java/org/apache/giraph/rexster/utils/RexsterUtils.java e669ca9 giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestAbstractRexsterInputFormat.java 09b27d3 giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatInputFormat.java PRE-CREATION giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatOutputFormat.java PRE-CREATION giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatVertexInputFormat.java a68db67 Diff: https://reviews.apache.org/r/14046/diff/ Testing ------- mvn verify with java 6 passed. Thanks, Armando
