----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14046/ -----------------------------------------------------------
(Updated Nov. 6, 2013, 11:11 a.m.) Review request for giraph. Changes ------- updated the diff for the current trunk (on github). Repository: giraph-git Description ------- This patch is intended to refactor the way zookeeper list is kept in the configuration. In this manner the list is available also in other classes different from the services (BspService) which may benefit of zookeeper functionalities. I introduce the change of semantic of this type: conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal() Diffs (updated) ----- giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java 34f4b51 giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java f176bfe giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 6f32e46 giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 3939d49 giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java f043c61 giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java a92ddf8 giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnClient.java ab6564e Diff: https://reviews.apache.org/r/14046/diff/ Testing ------- mvn verify with java 6 passed. Thanks, Armando
