autumnust commented on a change in pull request #3081:
URL: https://github.com/apache/incubator-gobblin/pull/3081#discussion_r470928416



##########
File path: gobblin-admin/build.gradle
##########
@@ -34,6 +34,7 @@ dependencies {
     compile externalDependency.jodaTime
 
     testCompile externalDependency.testng
+    testCompile externalDependency.slf4jToLog4j

Review comment:
       why this is only added for test-compile (isn't that the case we use 
slf4j all over the places? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to