autumnust commented on a change in pull request #3081:
URL: https://github.com/apache/incubator-gobblin/pull/3081#discussion_r470936412
##########
File path: gradle/scripts/dependencyDefinitions.gradle
##########
@@ -180,13 +180,16 @@ ext.externalDependency = [
'reactivex': 'io.reactivex.rxjava2:rxjava:2.1.0',
"slf4j": [
"org.slf4j:slf4j-api:" + slf4jVersion,
- "org.slf4j:slf4j-log4j12:" + slf4jVersion,
+ "org.slf4j:log4j-over-slf4j:" + slf4jVersion,
Review comment:
OK now I understand it through reading this
[link](http://www.slf4j.org/legacy.html#:~:text=SLF4J%20ship%20with%20a%20module,simply%20by%20replacing%20the%20log4j.)
!
##########
File path: gobblin-admin/build.gradle
##########
@@ -34,6 +34,7 @@ dependencies {
compile externalDependency.jodaTime
testCompile externalDependency.testng
+ testCompile externalDependency.slf4jToLog4j
Review comment:
OK I need a bit more clarification here:
I think the purpose of adding this line is to add the binding in these test
classes to make the log4j being picked as the implementation of slf4j ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
