autumnust commented on a change in pull request #3081:
URL: https://github.com/apache/incubator-gobblin/pull/3081#discussion_r477603810
##########
File path: gradle/scripts/dependencyDefinitions.gradle
##########
@@ -180,13 +180,16 @@ ext.externalDependency = [
'reactivex': 'io.reactivex.rxjava2:rxjava:2.1.0',
"slf4j": [
"org.slf4j:slf4j-api:" + slf4jVersion,
- "org.slf4j:slf4j-log4j12:" + slf4jVersion,
+ "org.slf4j:log4j-over-slf4j:" + slf4jVersion,
"org.slf4j:jcl-over-slf4j:" + slf4jVersion
],
"log4j": [
Review comment:
Gotcha. You may also want to check the conflicts, after which I can
merge this so it could be tested in larger scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
