sv2000 commented on a change in pull request #3076:
URL: https://github.com/apache/incubator-gobblin/pull/3076#discussion_r487319380
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Should this be grouped into SourceMetrics and have the metric name as
"gobblin.source.numWorkUnits.created" to be consistent with other metric names?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
