sv2000 commented on a change in pull request #3076:
URL: https://github.com/apache/incubator-gobblin/pull/3076#discussion_r487321615
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
On second reading - Is numWorkunits a CodaHale metric that gets emitted
via MetricReporter? I think the metrics listed in MetricNames are intended for
the reporter metrics. If numWorkUnits is intended for a different purpose,
let's not add it into MetricNames class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
