arjun4084346 commented on a change in pull request #3076:
URL: https://github.com/apache/incubator-gobblin/pull/3076#discussion_r487283604
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec,
Config sysConfig) {
Config config =
jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig,
additionalConfigsPrefix));
+ config =
config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig,
additionalConfigsPrefix));
Review comment:
It will be dropped, i.e. will return b
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Are you suggesting a new class SourceMetrics ?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
Right, it's not a codahale metric name. Can you suggest a right place?
The current class (AbstractJobLauncher) ?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec,
Config sysConfig) {
Config config =
jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig,
additionalConfigsPrefix));
+ config =
config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig,
additionalConfigsPrefix));
Review comment:
It will be dropped, i.e. will return b
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Are you suggesting a new class SourceMetrics ?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
Right, it's not a codahale metric name. Can you suggest a right place?
The current class (AbstractJobLauncher) ?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec,
Config sysConfig) {
Config config =
jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig,
additionalConfigsPrefix));
+ config =
config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig,
additionalConfigsPrefix));
Review comment:
It will be dropped, i.e. will return b
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Are you suggesting a new class SourceMetrics ?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
Right, it's not a codahale metric name. Can you suggest a right place?
The current class (AbstractJobLauncher) ?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec,
Config sysConfig) {
Config config =
jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig,
additionalConfigsPrefix));
+ config =
config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig,
additionalConfigsPrefix));
Review comment:
It will be dropped, i.e. will return b
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Are you suggesting a new class SourceMetrics ?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
Right, it's not a codahale metric name. Can you suggest a right place?
The current class (AbstractJobLauncher) ?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec,
Config sysConfig) {
Config config =
jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig,
additionalConfigsPrefix));
+ config =
config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig,
additionalConfigsPrefix));
Review comment:
It will be dropped, i.e. will return b
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Are you suggesting a new class SourceMetrics ?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
Right, it's not a codahale metric name. Can you suggest a right place?
The current class (AbstractJobLauncher) ?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec,
Config sysConfig) {
Config config =
jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig,
additionalConfigsPrefix));
+ config =
config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig,
additionalConfigsPrefix));
Review comment:
It will be dropped, i.e. will return b
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Are you suggesting a new class SourceMetrics ?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
Right, it's not a codahale metric name. Can you suggest a right place?
The current class (AbstractJobLauncher) ?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec,
Config sysConfig) {
Config config =
jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig,
additionalConfigsPrefix));
+ config =
config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig,
additionalConfigsPrefix));
Review comment:
It will be dropped, i.e. will return b
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/MetricNames.java
##########
@@ -22,6 +22,8 @@
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
Review comment:
Are you suggesting a new class SourceMetrics ?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -414,6 +415,9 @@ public void apply(JobListener jobListener, JobContext
jobContext)
workUnitsCreationTimer.stop(this.eventMetadataGenerator.getMetadata(this.jobContext,
EventName.WORK_UNITS_CREATION));
+ this.jobContext.getJobState().setProp(
+ MetricNames.NUM_WORKUNITS,
workUnitStream.getMaterializedWorkUnitCollection().size());
Review comment:
Right, it's not a codahale metric name. Can you suggest a right place?
The current class (AbstractJobLauncher) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
