[
https://issues.apache.org/jira/browse/GOBBLIN-1402?focusedWorklogId=560668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560668
]
ASF GitHub Bot logged work on GOBBLIN-1402:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/21 21:44
Start Date: 03/Mar/21 21:44
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3238:
URL: https://github.com/apache/gobblin/pull/3238#discussion_r586815404
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
##########
@@ -301,6 +302,42 @@ public void testLocalGroupOwnershipUpdates() throws
Exception {
_client.deleteFlowConfig(new
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_7));
}
+
+ @Test (expectedExceptions = RestLiResponseException.class)
+ public void testGroupUpdateRejected() throws Exception {
+ ServiceRequester testRequester = new ServiceRequester("testName",
"USER_PRINCIPAL", "testFrom");
+ _requesterService.setRequester(testRequester);
+ Map<String, String> flowProperties = Maps.newHashMap();
+
+ FlowConfig flowConfig = new FlowConfig().setId(new
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_8))
+ .setTemplateUris(TEST_TEMPLATE_URI)
+ .setProperties(new StringMap(flowProperties))
+ .setOwningGroup("testGroup");
+
+ _client.createFlowConfig(flowConfig);
+
+ flowConfig.setOwningGroup("testGroup2");
+ _client.updateFlowConfig(flowConfig);
Review comment:
The point is to check that a user cannot update a flow's owningGroup to
a group that that user is not a part of (the test user is not part of the group
`testGroup2`). Previously we only checked this condition on flow creation, but
you could still update it to a group you are not part of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 560668)
Time Spent: 1h (was: 50m)
> Allow flow's requester list/owner to be updated
> -----------------------------------------------
>
> Key: GOBBLIN-1402
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1402
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
