[ 
https://issues.apache.org/jira/browse/GOBBLIN-1402?focusedWorklogId=560732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560732
 ]

ASF GitHub Bot logged work on GOBBLIN-1402:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Mar/21 23:14
            Start Date: 03/Mar/21 23:14
    Worklog Time Spent: 10m 
      Work Description: jack-moseley commented on a change in pull request 
#3238:
URL: https://github.com/apache/gobblin/pull/3238#discussion_r586864328



##########
File path: 
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
##########
@@ -301,6 +302,42 @@ public void testLocalGroupOwnershipUpdates() throws 
Exception {
     _client.deleteFlowConfig(new 
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_7));
   }
 
+
+  @Test (expectedExceptions = RestLiResponseException.class)

Review comment:
       Actually I think I prefer it that way, because we can just check the 
HTTP status code instead, checking error messages seems a bit worse because if 
we ever want to change the message sent it will affect all the tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 560732)
    Time Spent: 2h 10m  (was: 2h)

> Allow flow's requester list/owner to be updated
> -----------------------------------------------
>
>                 Key: GOBBLIN-1402
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1402
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to