[
https://issues.apache.org/jira/browse/GOBBLIN-1402?focusedWorklogId=560733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560733
]
ASF GitHub Bot logged work on GOBBLIN-1402:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/21 23:15
Start Date: 03/Mar/21 23:15
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3238:
URL: https://github.com/apache/gobblin/pull/3238#discussion_r586865437
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
##########
@@ -301,6 +302,42 @@ public void testLocalGroupOwnershipUpdates() throws
Exception {
_client.deleteFlowConfig(new
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_7));
}
+
+ @Test (expectedExceptions = RestLiResponseException.class)
+ public void testGroupUpdateRejected() throws Exception {
+ ServiceRequester testRequester = new ServiceRequester("testName",
"USER_PRINCIPAL", "testFrom");
+ _requesterService.setRequester(testRequester);
+ Map<String, String> flowProperties = Maps.newHashMap();
+
+ FlowConfig flowConfig = new FlowConfig().setId(new
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_8))
+ .setTemplateUris(TEST_TEMPLATE_URI)
+ .setProperties(new StringMap(flowProperties))
+ .setOwningGroup("testGroup");
+
+ _client.createFlowConfig(flowConfig);
+
+ flowConfig.setOwningGroup("testGroup2");
+ _client.updateFlowConfig(flowConfig);
Review comment:
Actually it looks like that test also deletes the original group
(testGroup1), which was causing some confusing behaviour, and I think could
affect the already existing tests as well depending on what order they run in.
I made that one depend on all the ones that rely on that group being there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 560733)
Time Spent: 2h 20m (was: 2h 10m)
> Allow flow's requester list/owner to be updated
> -----------------------------------------------
>
> Key: GOBBLIN-1402
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1402
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
