[
https://issues.apache.org/jira/browse/GOBBLIN-1439?focusedWorklogId=591888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591888
]
ASF GitHub Bot logged work on GOBBLIN-1439:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/21 16:12
Start Date: 01/May/21 16:12
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3273:
URL: https://github.com/apache/gobblin/pull/3273#discussion_r624530593
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
##########
@@ -338,6 +339,14 @@ public Spec getSpecWrapper(URI uri) {
if (triggerListener) {
AddSpecResponse<CallbacksDispatcher.CallbackResults<SpecCatalogListener,
AddSpecResponse>> response = this.listeners.onAddSpec(flowSpec);
+ // If flow fails callbacks, need to prevent adding the flow to the
catalog
+ if (!response.getValue().getFailures().isEmpty()) {
+ for (Map.Entry<SpecCatalogListener, CallbackResult<AddSpecResponse>>
entry: response.getValue().getFailures().entrySet()) {
+
flowSpec.getCompilationErrors().add(ExceptionUtils.getStackTrace(entry.getValue().getError()));
+ }
+ responseMap.put(ServiceConfigKeys.COMPILATION_SUCCESSFUL, new
AddSpecResponse<>("false"));
Review comment:
Can we reuse `if (isCompileSuccessful(responseMap)) {` block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 591888)
Time Spent: 1h (was: 50m)
> Flows that fail to compile can still be added to Flow Catalog, and block the
> scheduler silently
> -----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1439
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1439
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> FlowSpecs that fail to compile can cause the Job Scheduler to silently fail
> adding jobs. Intended behaviour is to reject flows that fail compilation
> errors, and if encountering a flow that fails to compile, log it and continue
> scheduling the rest of the flows instead of silently failing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
