[
https://issues.apache.org/jira/browse/GOBBLIN-1439?focusedWorklogId=592472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592472
]
ASF GitHub Bot logged work on GOBBLIN-1439:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/21 23:31
Start Date: 03/May/21 23:31
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3273:
URL: https://github.com/apache/gobblin/pull/3273#discussion_r625429393
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MockSpecCatalogListener.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.api;
+
+import java.net.URI;
+import java.util.Properties;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.runtime.spec_catalog.AddSpecResponse;
+
+
+public class MockSpecCatalogListener implements SpecCatalogListener {
Review comment:
Thanks for the suggestion, going to use the Mockito mocks and clean it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 592472)
Time Spent: 1.5h (was: 1h 20m)
> Flows that fail to compile can still be added to Flow Catalog, and block the
> scheduler silently
> -----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1439
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1439
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> FlowSpecs that fail to compile can cause the Job Scheduler to silently fail
> adding jobs. Intended behaviour is to reject flows that fail compilation
> errors, and if encountering a flow that fails to compile, log it and continue
> scheduling the rest of the flows instead of silently failing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
