[
https://issues.apache.org/jira/browse/GOBBLIN-1439?focusedWorklogId=592474&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592474
]
ASF GitHub Bot logged work on GOBBLIN-1439:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/21 23:31
Start Date: 03/May/21 23:31
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3273:
URL: https://github.com/apache/gobblin/pull/3273#discussion_r625429487
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
##########
@@ -366,11 +376,17 @@ public Spec getSpecWrapper(URI uri) {
return responseMap;
}
- public static boolean isCompileSuccessful(Map<String, AddSpecResponse>
responseMap) {
- AddSpecResponse<String> addSpecResponse = responseMap.getOrDefault(
- ServiceConfigKeys.GOBBLIN_SERVICE_JOB_SCHEDULER_LISTENER_CLASS, new
AddSpecResponse<>(""));
-
- return isCompileSuccessful(addSpecResponse.getValue());
+ public boolean isCompileSuccessful(Map<String, AddSpecResponse> responseMap)
{
+ for (SpecCatalogListener listener: this.listeners.getListeners()) {
+ String listenerClass = listener.getClass().getCanonicalName();
+ AddSpecResponse<String> addSpecResponse =
Review comment:
I needed this originally for testing purposes and potentially for
extensibility but realized that I can mock the name of the expected listener
instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 592474)
Time Spent: 1h 50m (was: 1h 40m)
> Flows that fail to compile can still be added to Flow Catalog, and block the
> scheduler silently
> -----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1439
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1439
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> FlowSpecs that fail to compile can cause the Job Scheduler to silently fail
> adding jobs. Intended behaviour is to reject flows that fail compilation
> errors, and if encountering a flow that fails to compile, log it and continue
> scheduling the rest of the flows instead of silently failing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
