[
https://issues.apache.org/jira/browse/GOBBLIN-1446?focusedWorklogId=598974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598974
]
ASF GitHub Bot logged work on GOBBLIN-1446:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/21 02:38
Start Date: 19/May/21 02:38
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request #3285:
URL: https://github.com/apache/gobblin/pull/3285
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following
[Gobblin-1446](https://issues.apache.org/jira/browse/GOBBLIN/) issues and
references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1446
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
When using the two filters cron-schedule and property-filter during search
for flow-configs we do not handle the case when the parameters have white
spaces in them. To encode the spaces in the curli url we use %20 and need to
update GaaS endpoints to be able to parse them, so I have added code to replace
%20 with a white space.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
My PR did not include unit testing as the filter functionality for flows
could not be tested locally with FSSpecStore, however I verified that the
encoding and decoding functionality with the debugger and deployment of open
source GaaS via Docker.
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 598974)
Remaining Estimate: 0h
Time Spent: 10m
> Parse Whitespace in Curli Request from GaaS
> -------------------------------------------
>
> Key: GOBBLIN-1446
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1446
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Affects Versions: 0.15.0
> Reporter: Urmi Mustafi
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When using the two filters cron-schedule and property-filter during search
> for flow-configs we do not handle the case when the parameters have white
> spaces in them. To encode the spaces in the curli url we use %20 and need to
> update GaaS endpoints to be able to parse them, so I have added code to
> replace %20 with a white space.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
