[
https://issues.apache.org/jira/browse/GOBBLIN-1446?focusedWorklogId=598989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598989
]
ASF GitHub Bot logged work on GOBBLIN-1446:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/21 03:21
Start Date: 19/May/21 03:21
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3285:
URL: https://github.com/apache/gobblin/pull/3285#issuecomment-843709285
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3285?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3285](https://codecov.io/gh/apache/gobblin/pull/3285?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e8c6287) into
[master](https://codecov.io/gh/apache/gobblin/commit/2e5eacad5f52cbae88b9cb7b70cb175765fe4d3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2e5eaca) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3285?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3285 +/- ##
=========================================
Coverage 46.53% 46.53%
Complexity 10028 10028
=========================================
Files 2037 2037
Lines 79273 79279 +6
Branches 8841 8841
=========================================
+ Hits 36887 36893 +6
- Misses 38960 38963 +3
+ Partials 3426 3423 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3285?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/gobblin/pull/3285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==)
| `59.78% <0.00%> (-4.18%)` | `11.00 <0.00> (ø)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.78% <0.00%> (+0.32%)` | `35.00% <0.00%> (ø%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/gobblin/pull/3285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0.00%> (+1.42%)` | `4.00% <0.00%> (ø%)` | |
|
[...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=)
| `49.51% <0.00%> (+1.94%)` | `12.00% <0.00%> (ø%)` | |
|
[...he/gobblin/source/PartitionAwareFileRetriever.java](https://codecov.io/gh/apache/gobblin/pull/3285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9QYXJ0aXRpb25Bd2FyZUZpbGVSZXRyaWV2ZXIuamF2YQ==)
| `55.55% <0.00%> (+7.40%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3285?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3285?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[2e5eaca...e8c6287](https://codecov.io/gh/apache/gobblin/pull/3285?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 598989)
Time Spent: 0.5h (was: 20m)
> Parse Whitespace in Curli Request from GaaS
> -------------------------------------------
>
> Key: GOBBLIN-1446
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1446
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Affects Versions: 0.15.0
> Reporter: Urmi Mustafi
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When using the two filters cron-schedule and property-filter during search
> for flow-configs we do not handle the case when the parameters have white
> spaces in them. To encode the spaces in the curli url we use %20 and need to
> update GaaS endpoints to be able to parse them, so I have added code to
> replace %20 with a white space.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
