[
https://issues.apache.org/jira/browse/GOBBLIN-1446?focusedWorklogId=599535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-599535
]
ASF GitHub Bot logged work on GOBBLIN-1446:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/21 23:57
Start Date: 19/May/21 23:57
Worklog Time Spent: 10m
Work Description: umustafi commented on a change in pull request #3285:
URL: https://github.com/apache/gobblin/pull/3285#discussion_r635656994
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigV2Client.java
##########
@@ -214,14 +216,24 @@ public FlowConfig getFlowConfig(FlowId flowId)
String propertyFilter) throws RemoteInvocationException {
LOG.debug("getAllFlowConfigs called");
- FindRequest<FlowConfig> getRequest =
_flowconfigsV2RequestBuilders.findByFilterFlows()
-
.flowGroupParam(flowGroup).flowNameParam(flowName).templateUriParam(templateUri).userToProxyParam(userToProxy)
-
.sourceIdentifierParam(sourceIdentifier).destinationIdentifierParam(destinationIdentifier).scheduleParam(schedule)
-
.isRunImmediatelyParam(isRunImmediately).owningGroupParam(owningGroup).propertyFilterParam(propertyFilter).build();
+ // the following parameters may contain white space
+ try {
+ String decodedSchedule = URLDecoder.decode(schedule,
StandardCharsets.UTF_8.toString());
Review comment:
Double checked the args received by GaaS on EI and the URL encoding of
spaces is actually working (rest.li must be doing it), but the search
functionality itself for schedules appears to be broken. Searching with encoded
spaces on the property filter parameter does work. Cancelling the PR request
then and adding a ticket for the search functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 599535)
Time Spent: 1h (was: 50m)
> Parse Whitespace in Curli Request from GaaS
> -------------------------------------------
>
> Key: GOBBLIN-1446
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1446
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Affects Versions: 0.15.0
> Reporter: Urmi Mustafi
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When using the two filters cron-schedule and property-filter during search
> for flow-configs we do not handle the case when the parameters have white
> spaces in them. To encode the spaces in the curli url we use %20 and need to
> update GaaS endpoints to be able to parse them, so I have added code to
> replace %20 with a white space.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
