arjun4084346 commented on a change in pull request #3281:
URL: https://github.com/apache/gobblin/pull/3281#discussion_r642611879
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -146,26 +148,12 @@ public Orchestrator(Config config,
Optional<TopologyCatalog> topologyCatalog, Op
ServiceConfigKeys.DEFAULT_FLOW_CONCURRENCY_ALLOWED);
}
- public Orchestrator(Config config, Optional<TopologyCatalog>
topologyCatalog, Optional<DagManager> dagManager, Optional<Logger> log) {
- this(config, topologyCatalog, dagManager, log, true);
- }
-
- public Orchestrator(Config config, Optional<TopologyCatalog>
topologyCatalog, Optional<DagManager> dagManager, Logger log) {
- this(config, topologyCatalog, dagManager, Optional.of(log));
+ @Inject
+ public Orchestrator(Config config, FlowStatusGenerator flowStatusGenerator,
Optional<TopologyCatalog> topologyCatalog,
+ Optional<DagManager> dagManager, Optional<Logger> log) {
+ this(config, topologyCatalog, dagManager, log, flowStatusGenerator, true);
Review comment:
Are we sure about removing these public constructors? Looks redundant to
me though, but can be used by external users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
