aplex commented on a change in pull request #3281:
URL: https://github.com/apache/gobblin/pull/3281#discussion_r647042853
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -192,7 +193,7 @@ public String toString() {
private volatile boolean isActive = false;
- public DagManager(Config config, boolean instrumentationEnabled) {
+ public DagManager(Config config, JobStatusRetriever jobStatusRetriever,
boolean instrumentationEnabled) {
Review comment:
It's not a part of the user-facing API, just an internal class. It
should be instantiated by dependency injection framework, so even if new
dependencies are added, they should be injected automatically.
So, I don't think backward compatibility is important here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
