aplex commented on a change in pull request #3281:
URL: https://github.com/apache/gobblin/pull/3281#discussion_r643255378
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -146,26 +148,12 @@ public Orchestrator(Config config,
Optional<TopologyCatalog> topologyCatalog, Op
ServiceConfigKeys.DEFAULT_FLOW_CONCURRENCY_ALLOWED);
}
- public Orchestrator(Config config, Optional<TopologyCatalog>
topologyCatalog, Optional<DagManager> dagManager, Optional<Logger> log) {
- this(config, topologyCatalog, dagManager, log, true);
- }
-
- public Orchestrator(Config config, Optional<TopologyCatalog>
topologyCatalog, Optional<DagManager> dagManager, Logger log) {
- this(config, topologyCatalog, dagManager, Optional.of(log));
+ @Inject
+ public Orchestrator(Config config, FlowStatusGenerator flowStatusGenerator,
Optional<TopologyCatalog> topologyCatalog,
+ Optional<DagManager> dagManager, Optional<Logger> log) {
+ this(config, topologyCatalog, dagManager, log, flowStatusGenerator, true);
Review comment:
This class should be created using dependency injection, so other
constructors should not be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
