jack-moseley commented on a change in pull request #3333:
URL: https://github.com/apache/gobblin/pull/3333#discussion_r670930283
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java
##########
@@ -191,6 +191,7 @@
protected Optional<HelixLeaderState> helixLeaderGauges;
+ public D2Announcer d2Announcer;
Review comment:
Right now I am just directly setting this field after the
`GobblinServiceManager` is initialized.
How does the dependency injection work exactly? Like I see for the
`FlowStatusGenerator` we call `binder.bind(FlowStatusGenerator.class);`, does
that construct a `FlowStatusGenerator` and inject it, and if so how does it
provide arguments to the constructor?
I needed to, in our internal code, construct a subclass of D2Announcer and
provide it to `GobblinServiceManager`, I couldn't figure out how to do it in a
different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
