aplex commented on a change in pull request #3333:
URL: https://github.com/apache/gobblin/pull/3333#discussion_r671531386
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/D2Announcer.java
##########
@@ -0,0 +1,17 @@
+package org.apache.gobblin.service.modules.core;
+
+
+/**
+ * Interface for marking up/down D2 servers on gobblin service startup. This
is only required if using delayed announcement.
+ */
+public interface D2Announcer {
+ /**
+ * Mark up D2 servers
+ */
+ void markUpServers();
Review comment:
I suggest to double-check with D2 docs/code that it will actually only
mark the current server. If it is going to mark all servers as down, that
wouldn't help us with routing data to master node.
If it indeed just works with the current server, then it looks like a
confusing API on D2 side. We don't have to carry it inside our code base, and
can make it a bit more correct and meaningful in our context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
