aplex commented on a change in pull request #3333:
URL: https://github.com/apache/gobblin/pull/3333#discussion_r671535952
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java
##########
@@ -191,6 +191,7 @@
protected Optional<HelixLeaderState> helixLeaderGauges;
+ public D2Announcer d2Announcer;
Review comment:
For li-specific implementations, you can change
LiGobblinServiceGuiceModule to override the defaults and inject private
implementations. If your class depends on other interfaces registered in Guice,
they will be injected into its constructor. Search for "@Inject" annotation on
constructors in other classes to see how it works.
if the subclass of D2Announcer depends on some instances that you don't
create yourself, you can register such instances in Guice like this -
https://github.com/apache/gobblin/blob/b5e32b158bd713c45caa5b4b8866f8a4c4fc3a29/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceGuiceModule.java#L104
, or create a provider for them/D2Announcer like this -
https://github.com/apache/gobblin/blob/b5e32b158bd713c45caa5b4b8866f8a4c4fc3a29/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceGuiceModule.java#L184
Here is more info on how Guice works -
https://github.com/google/guice/wiki/Motivation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
