[ 
https://issues.apache.org/jira/browse/GOBBLIN-1509?focusedWorklogId=636297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636297
 ]

ASF GitHub Bot logged work on GOBBLIN-1509:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/21 07:28
            Start Date: 10/Aug/21 07:28
    Worklog Time Spent: 10m 
      Work Description: phet commented on a change in pull request #3357:
URL: https://github.com/apache/gobblin/pull/3357#discussion_r685762496



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -288,13 +287,28 @@ public void orchestrate(Spec spec) throws Exception {
       
flowMetadata.putIfAbsent(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD,
           
jobExecutionPlanDag.getNodes().get(0).getValue().getJobSpec().getConfigAsProperties().getProperty(ConfigurationKeys.FLOW_EXECUTION_ID_KEY));
 
-      if (flowCompilationTimer != null) {
-        flowCompilationTimer.stop(flowMetadata);
+      if (flowCompilationTimer.isPresent()) {
+        flowCompilationTimer.get().stop(flowMetadata);
       }
 
       if (this.dagManager.isPresent()) {
-        //Send the dag to the DagManager.
-        this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+        try {
+          //Send the dag to the DagManager.
+          this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+        } catch (Exception ex) {
+          // pronounce failed before stack unwinds, to ensure flow not 
marooned in `COMPILED` state; (failure likely attributable to DB 
connection/failover)
+          String context = String.format("flow: %s; exec: %s",
+              DagManagerUtils.getFlowId(jobExecutionPlanDag).toString(),
+              DagManagerUtils.getFlowExecId(jobExecutionPlanDag));
+          String failureMessage = "Failed to add Job Execution Plan due to: " 
+ ex.getMessage();
+          _log.warn(String.format("[%s] %s", context, failureMessage));

Review comment:
       I didn't want to double up on the stack trace, since I re-throw just 
after.  the final handler can log the trace.  I give only the exception's 
message for correlation.
   
   in the thread below, we could discuss whether to log here at all.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 636297)
    Time Spent: 1h  (was: 50m)

> Ensure flows transition to FAILED and not stuck in COMPILED upon 
> DagManager::addDag error
> -----------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1509
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1509
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Kip Kohn
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Presently, addDag failure leaves the flow marooned in the COMPILED state, as 
> the warranted FLOW_FAILED event is never sent.  Particularly insidious is 
> that scheduled flows with their execution stuck in COMPILED miss their next 
> execution, unless `flow.allowConcurrentExecutions` is set.  Thus the 
> scheduled flow is stuck in its entirety, not merely a single execution.
> One observed cause of addDag failure is when the DagStateStore is backed by a 
> replicated DB (e.g. MySqlDagStateStore) that just switched leaders. Cached 
> connections in the pool may suddently point to a read-only follower unable to 
> DagStateStore::writeCheckpoint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to