[ 
https://issues.apache.org/jira/browse/GOBBLIN-1509?focusedWorklogId=636298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636298
 ]

ASF GitHub Bot logged work on GOBBLIN-1509:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/21 07:29
            Start Date: 10/Aug/21 07:29
    Worklog Time Spent: 10m 
      Work Description: phet commented on a change in pull request #3357:
URL: https://github.com/apache/gobblin/pull/3357#discussion_r685762840



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -288,13 +287,28 @@ public void orchestrate(Spec spec) throws Exception {
       
flowMetadata.putIfAbsent(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD,
           
jobExecutionPlanDag.getNodes().get(0).getValue().getJobSpec().getConfigAsProperties().getProperty(ConfigurationKeys.FLOW_EXECUTION_ID_KEY));
 
-      if (flowCompilationTimer != null) {
-        flowCompilationTimer.stop(flowMetadata);
+      if (flowCompilationTimer.isPresent()) {
+        flowCompilationTimer.get().stop(flowMetadata);
       }
 
       if (this.dagManager.isPresent()) {
-        //Send the dag to the DagManager.
-        this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+        try {
+          //Send the dag to the DagManager.
+          this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+        } catch (Exception ex) {

Review comment:
       `GoblinServiceJobScheduler.runJob` is the only caller, and it both 
catches and logs `Exception`.  I sought to avoid a duplicate stack trace (since 
we continue to unwinding).  I dropped the log line in, to report the flow 
execution ID.
   
   would you suggest not to log here at all?  as an example, the two log 
entries look like:
   ```
   2021/08/10 00:08:45.902 WARN [GobblinServiceManager] [JobScheduler-1] 
[shared-gobblin-service-war] [] [flow: {flowGroup=testKip, flowName=test001}; 
exec: 1628579325837] Failed to add 
   Job Execution Plan due to: No, I won't add the DAG, dawg!
   2021/08/10 00:08:45.903 ERROR [GobblinServiceManager] [JobScheduler-1] 
[shared-gobblin-service-war] [] Failed to run job gobblin-flow:/testKip/test001
   org.apache.gobblin.runtime.JobException: Failed to run Spec: 
gobblin-flow:/testKip/test001
           at 
org.apache.gobblin.service.modules.scheduler.GobblinServiceJobScheduler.runJob(GobblinServiceJobScheduler.java:279)
 ~[gobblin-service-fat-1.0.46-all.jar:?]
           at 
org.apache.gobblin.service.modules.scheduler.GobblinServiceJobScheduler$NonScheduledJobRunner.run(GobblinServiceJobScheduler.java:476)
 [gobblin-service-fat-1.0.46-all.jar:?]
           at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_172]
           at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_172]
           at java.lang.Thread.run(Thread.java:748) [?:1.8.0_172]
   Caused by: java.io.IOException: No, I won't add the DAG, dawg!
           at 
org.apache.gobblin.service.modules.orchestration.DagManager.addDag(DagManager.java:266)
 ~[gobblin-service-fat-1.0.46-all.jar:?]
           at 
org.apache.gobblin.service.modules.orchestration.Orchestrator.orchestrate(Orchestrator.java:297)
 ~[gobblin-service-fat-1.0.46-all.jar:?]
           at 
org.apache.gobblin.service.modules.scheduler.GobblinServiceJobScheduler.runJob(GobblinServiceJobScheduler.java:277)
 ~[gobblin-service-fat-1.0.46-all.jar:?]
           ... 4 more
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 636298)
    Time Spent: 1h 10m  (was: 1h)

> Ensure flows transition to FAILED and not stuck in COMPILED upon 
> DagManager::addDag error
> -----------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1509
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1509
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Kip Kohn
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Presently, addDag failure leaves the flow marooned in the COMPILED state, as 
> the warranted FLOW_FAILED event is never sent.  Particularly insidious is 
> that scheduled flows with their execution stuck in COMPILED miss their next 
> execution, unless `flow.allowConcurrentExecutions` is set.  Thus the 
> scheduled flow is stuck in its entirety, not merely a single execution.
> One observed cause of addDag failure is when the DagStateStore is backed by a 
> replicated DB (e.g. MySqlDagStateStore) that just switched leaders. Cached 
> connections in the pool may suddently point to a read-only follower unable to 
> DagStateStore::writeCheckpoint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to