[ 
https://issues.apache.org/jira/browse/GOBBLIN-1509?focusedWorklogId=637277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637277
 ]

ASF GitHub Bot logged work on GOBBLIN-1509:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Aug/21 07:47
            Start Date: 12/Aug/21 07:47
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter edited a comment on pull request 
#3357:
URL: https://github.com/apache/gobblin/pull/3357#issuecomment-895570306


   # 
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3357?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#3357](https://codecov.io/gh/apache/gobblin/pull/3357?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (6d49646) into 
[master](https://codecov.io/gh/apache/gobblin/commit/de94515d04ea615bdff86b306f34f5361e1725e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (de94515) will **decrease** coverage by `3.40%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/gobblin/pull/3357/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3357      +/-   ##
   ============================================
   - Coverage     46.43%   43.03%   -3.41%     
   + Complexity    10120     1944    -8176     
   ============================================
     Files          2052      394    -1658     
     Lines         79656    16897   -62759     
     Branches       8896     2082    -6814     
   ============================================
   - Hits          36991     7272   -29719     
   + Misses        39226     8823   -30403     
   + Partials       3439      802    -2637     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/gobblin/pull/3357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...g/apache/gobblin/util/filters/RegexPathFilter.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsdGVycy9SZWdleFBhdGhGaWx0ZXIuamF2YQ==)
 | `72.72% <0.00%> (-16.17%)` | :arrow_down: |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
   | 
[...ore/util/DatabaseJobHistoryStoreSchemaManager.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL3V0aWwvRGF0YWJhc2VKb2JIaXN0b3J5U3RvcmVTY2hlbWFNYW5hZ2VyLmphdmE=)
 | `29.31% <0.00%> (-2.36%)` | :arrow_down: |
   | 
[...che/gobblin/metastore/DatabaseJobHistoryStore.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFiYXNlSm9iSGlzdG9yeVN0b3JlLmphdmE=)
 | `77.77% <0.00%> (-0.49%)` | :arrow_down: |
   | 
[.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh)
 | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
   | 
[.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh)
 | `8.16% <0.00%> (ø)` | |
   | 
[...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=)
 | `90.90% <0.00%> (ø)` | |
   | 
[.../mapreduce/orc/OrcValueCombineFileInputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNWYWx1ZUNvbWJpbmVGaWxlSW5wdXRGb3JtYXQuamF2YQ==)
 | | |
   | 
[...org/apache/gobblin/service/FlowStatusResource.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzUmVzb3VyY2UuamF2YQ==)
 | | |
   | 
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
 | | |
   | ... and [1657 
more](https://codecov.io/gh/apache/gobblin/pull/3357/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/gobblin/pull/3357?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3357?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[de94515...6d49646](https://codecov.io/gh/apache/gobblin/pull/3357?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 637277)
    Time Spent: 1h 40m  (was: 1.5h)

> Ensure flows transition to FAILED and not stuck in COMPILED upon 
> DagManager::addDag error
> -----------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1509
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1509
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Kip Kohn
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Presently, addDag failure leaves the flow marooned in the COMPILED state, as 
> the warranted FLOW_FAILED event is never sent.  Particularly insidious is 
> that scheduled flows with their execution stuck in COMPILED miss their next 
> execution, unless `flow.allowConcurrentExecutions` is set.  Thus the 
> scheduled flow is stuck in its entirety, not merely a single execution.
> One observed cause of addDag failure is when the DagStateStore is backed by a 
> replicated DB (e.g. MySqlDagStateStore) that just switched leaders. Cached 
> connections in the pool may suddently point to a read-only follower unable to 
> DagStateStore::writeCheckpoint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to