[ 
https://issues.apache.org/jira/browse/GOBBLIN-1513?focusedWorklogId=636511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636511
 ]

ASF GitHub Bot logged work on GOBBLIN-1513:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/21 16:44
            Start Date: 10/Aug/21 16:44
    Worklog Time Spent: 10m 
      Work Description: aplex commented on a change in pull request #3361:
URL: https://github.com/apache/gobblin/pull/3361#discussion_r686139470



##########
File path: 
gobblin-utility/src/main/java/org/apache/gobblin/util/filters/RegexPathFilter.java
##########
@@ -34,6 +35,11 @@
 
   private final Pattern regex;
   private final boolean include;
+  public static final String REGEX = "path.filter.regex";

Review comment:
       So, is this path filter only used to filter source datasets?
   I can see that we specify the class using gobblin.dataset.path.filter.class 
. It could make sense to have the same "gobblin.dataset" prefix for this 
setting for consistency.
   
   Also, it could be better to keep those config settings together, so that 
they would be easily discovered.
   
   Usually, they land up in ConfigKeys class, but I can see that bunch of keys 
are defined in DatasetUtils. You can try to figure out if there is any reason 
to keep them there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 636511)
    Time Spent: 50m  (was: 40m)

> DatasetUtils.instantiatePathFilter cannot create any PathFilter except 
> HiddenFilter
> -----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1513
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1513
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Path filters are supposed to be provided by key 
> "gobblin.dataset.path.filter.class", but `instantiatePathFilter` only calls 
> the empty constructors for the path filter classes. Right now only 
> HiddenFilter can be created with empty constructor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to