[ 
https://issues.apache.org/jira/browse/GOBBLIN-1513?focusedWorklogId=636519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636519
 ]

ASF GitHub Bot logged work on GOBBLIN-1513:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/21 16:49
            Start Date: 10/Aug/21 16:49
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on a change in pull request 
#3361:
URL: https://github.com/apache/gobblin/pull/3361#discussion_r686145529



##########
File path: 
gobblin-utility/src/main/java/org/apache/gobblin/util/filters/RegexPathFilter.java
##########
@@ -34,6 +35,11 @@
 
   private final Pattern regex;
   private final boolean include;
+  public static final String REGEX = "path.filter.regex";

Review comment:
       imo, this and other path filters can be used to filter any path. They 
are not tied up with filtering only gobblin datasets.
   In past, there have been discussion about where to keep configs, a) in 
ConfigurationKeys or somewhere else along with other configs or b) in the class 
which actually use them.
   For now, I will move it to DatasetUtils




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 636519)
    Time Spent: 1h  (was: 50m)

> DatasetUtils.instantiatePathFilter cannot create any PathFilter except 
> HiddenFilter
> -----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1513
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1513
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Path filters are supposed to be provided by key 
> "gobblin.dataset.path.filter.class", but `instantiatePathFilter` only calls 
> the empty constructors for the path filter classes. Right now only 
> HiddenFilter can be created with empty constructor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to