[
https://issues.apache.org/jira/browse/GOBBLIN-1513?focusedWorklogId=637004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637004
]
ASF GitHub Bot logged work on GOBBLIN-1513:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/21 17:39
Start Date: 11/Aug/21 17:39
Worklog Time Spent: 10m
Work Description: arjun4084346 opened a new pull request #3361:
URL: https://github.com/apache/gobblin/pull/3361
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
@aplex please review
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1513
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Path filters are supposed to be provided by key
"gobblin.dataset.path.filter.class", but `instantiatePathFilter` only calls the
empty constructors for the path filter classes. Right now only HiddenFilter can
be created with empty constructor.
This PR will make a constructor for RegexPathFilter so that it can be used
with config "gobblin.dataset.path.filter.class"
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
added a unit test to test initialization and basic working of RegexPathFilter
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 637004)
Time Spent: 1h 20m (was: 1h 10m)
> DatasetUtils.instantiatePathFilter cannot create any PathFilter except
> HiddenFilter
> -----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1513
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1513
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Path filters are supposed to be provided by key
> "gobblin.dataset.path.filter.class", but `instantiatePathFilter` only calls
> the empty constructors for the path filter classes. Right now only
> HiddenFilter can be created with empty constructor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)