[
https://issues.apache.org/jira/browse/GOBBLIN-1656?focusedWorklogId=780046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780046
]
ASF GitHub Bot logged work on GOBBLIN-1656:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/22 16:38
Start Date: 09/Jun/22 16:38
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3516:
URL: https://github.com/apache/gobblin/pull/3516#discussion_r893731069
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java:
##########
@@ -60,9 +63,8 @@ public CreateKVResponse createFlowConfig(FlowConfig
flowConfig, boolean triggerL
}
log.info(createLog);
FlowSpec flowSpec = createFlowSpecForConfig(flowConfig);
- FlowStatusId flowStatusId = new FlowStatusId()
-
.setFlowName(flowSpec.getConfigAsProperties().getProperty(ConfigurationKeys.FLOW_NAME_KEY))
-
.setFlowGroup(flowSpec.getConfigAsProperties().getProperty(ConfigurationKeys.FLOW_GROUP_KEY));
+ FlowStatusId flowStatusId =
+ new
FlowStatusId().setFlowName(flowSpec.getConfigAsProperties().getProperty(ConfigurationKeys.FLOW_NAME_KEY)).setFlowGroup(flowSpec.getConfigAsProperties().getProperty(ConfigurationKeys.FLOW_GROUP_KEY));
Review Comment:
I think this got auto changed by my IDE, I can revert 😓
Issue Time Tracking
-------------------
Worklog Id: (was: 780046)
Time Spent: 3h (was: 2h 50m)
> Return different Http Status on GaaS if Quota is Exceeded
> ---------------------------------------------------------
>
> Key: GOBBLIN-1656
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1656
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> GaaS has quota limits for proxy users and flowGroups.
> When a user wants to create a flow that exceeds their specified quota, the
> flow should
> 1) Not be run
> 2) Return a http status code (i.e. 503) due to exceeding the resource. This
> allows clients to implement some wait and retry functionality
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
