[
https://issues.apache.org/jira/browse/GOBBLIN-1672?focusedWorklogId=797063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797063
]
ASF GitHub Bot logged work on GOBBLIN-1672:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 23:55
Start Date: 01/Aug/22 23:55
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3532:
URL: https://github.com/apache/gobblin/pull/3532#issuecomment-1201852581
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3532?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3532](https://codecov.io/gh/apache/gobblin/pull/3532?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(3117bdb) into
[master](https://codecov.io/gh/apache/gobblin/commit/9ce1e65aa36674742877b5aa2083412d85b5764f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(9ce1e65) will **decrease** coverage by `3.29%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3532 +/- ##
============================================
- Coverage 46.69% 43.39% -3.30%
+ Complexity 10432 2038 -8394
============================================
Files 2083 406 -1677
Lines 81516 17526 -63990
Branches 9100 2141 -6959
============================================
- Hits 38061 7605 -30456
+ Misses 39944 9072 -30872
+ Partials 3511 849 -2662
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3532?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-2.16%)` | :arrow_down: |
|
[...org/apache/gobblin/metrics/ServiceMetricNames.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvU2VydmljZU1ldHJpY05hbWVzLmphdmE=)
| | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| | |
|
[...hive/filter/DateRangePartitionFilterGenerator.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvRGF0ZVJhbmdlUGFydGl0aW9uRmlsdGVyR2VuZXJhdG9yLmphdmE=)
| | |
|
[...apache/gobblin/writer/SimpleDataWriterBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9TaW1wbGVEYXRhV3JpdGVyQnVpbGRlci5qYXZh)
| | |
|
[...n/yarn/event/GetApplicationReportFailureEvent.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vZXZlbnQvR2V0QXBwbGljYXRpb25SZXBvcnRGYWlsdXJlRXZlbnQuamF2YQ==)
| | |
|
[...org/apache/gobblin/writer/PartitionIdentifier.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnRpdGlvbklkZW50aWZpZXIuamF2YQ==)
| | |
|
[...he/gobblin/runtime/job\_catalog/JobCatalogBase.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2NhdGFsb2cvSm9iQ2F0YWxvZ0Jhc2UuamF2YQ==)
| | |
|
[...lin/compaction/mapreduce/orc/OrcKeyComparator.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNLZXlDb21wYXJhdG9yLmphdmE=)
| | |
|
[...ermark/FullPathCopyableFileWatermarkGenerator.java](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvd2F0ZXJtYXJrL0Z1bGxQYXRoQ29weWFibGVGaWxlV2F0ZXJtYXJrR2VuZXJhdG9yLmphdmE=)
| | |
| ... and [1670
more](https://codecov.io/gh/apache/gobblin/pull/3532/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
Help us with your feedback. Take ten seconds to tell us [how you rate
us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 797063)
Time Spent: 20m (was: 10m)
> Refactor metrics in dagmanager and add per spec executor metrics
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1672
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1672
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add the following metrics:
> 1. Success per executor
> 2. Fail per executor
> 3. SLA killed per executor
> 4. SLA killed per flowgroup
> 5. SLA killed per user
> 6. SLA killed overall
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
