[
https://issues.apache.org/jira/browse/GOBBLIN-1672?focusedWorklogId=797376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797376
]
ASF GitHub Bot logged work on GOBBLIN-1672:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/22 20:13
Start Date: 02/Aug/22 20:13
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3532:
URL: https://github.com/apache/gobblin/pull/3532#discussion_r935986637
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerTest.java:
##########
@@ -1053,6 +1062,150 @@ public void testEmitFlowMetricOnlyIfNotAdhoc() throws
URISyntaxException, IOExce
Assert.assertEquals(metricContext.getParent().get().getGauges().get(flowStateGaugeName1).getValue(),
DagManager.FlowState.SUCCESSFUL.value);
}
+ @Test (dependsOnMethods = "testEmitFlowMetricOnlyIfNotAdhoc")
+ public void testJobSlaKilledMetrics() throws URISyntaxException, IOException
{
+ long flowExecutionId = System.currentTimeMillis() - 10 * 60 * 1000;
Review Comment:
*nit
I use Duration.ofMinutes(10).toMillis() to keep it more readable
Issue Time Tracking
-------------------
Worklog Id: (was: 797376)
Time Spent: 0.5h (was: 20m)
> Refactor metrics in dagmanager and add per spec executor metrics
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1672
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1672
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add the following metrics:
> 1. Success per executor
> 2. Fail per executor
> 3. SLA killed per executor
> 4. SLA killed per flowgroup
> 5. SLA killed per user
> 6. SLA killed overall
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
