[ 
https://issues.apache.org/jira/browse/GOBBLIN-1672?focusedWorklogId=797391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797391
 ]

ASF GitHub Bot logged work on GOBBLIN-1672:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/22 21:13
            Start Date: 02/Aug/22 21:13
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3532:
URL: https://github.com/apache/gobblin/pull/3532#discussion_r936031836


##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerTest.java:
##########
@@ -779,15 +785,18 @@ public void testJobKilledSLAMetricsArePerExecutor() 
throws URISyntaxException, I
         thenReturn(jobStatusIterator2).
         thenReturn(jobStatusIterator3);
 
-    // Run the thread once. All 3 jobs should be emitted an sla exceeded event
+    // Run the thread once. All 3 jobs should be emitted a sla exceeded event

Review Comment:
   Actually, it should be in uppercase SLA, then intellij recognize the 'As' 
sound





Issue Time Tracking
-------------------

    Worklog Id:     (was: 797391)
    Time Spent: 1h 10m  (was: 1h)

> Refactor metrics in dagmanager and add per spec executor metrics
> ----------------------------------------------------------------
>
>                 Key: GOBBLIN-1672
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1672
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Add the following metrics:
> 1. Success per executor
> 2. Fail per executor
> 3. SLA killed per executor
> 4. SLA killed per flowgroup
> 5. SLA killed per user
> 6. SLA killed overall



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to