[ 
https://issues.apache.org/jira/browse/GOBBLIN-1696?focusedWorklogId=808473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-808473
 ]

ASF GitHub Bot logged work on GOBBLIN-1696:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/22 23:12
            Start Date: 13/Sep/22 23:12
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3548:
URL: https://github.com/apache/gobblin/pull/3548#discussion_r970155176


##########
gobblin-utility/src/main/java/org/apache/gobblin/util/filesystem/ExceptionCatchingPathAlterationListenerDecorator.java:
##########
@@ -111,4 +111,13 @@ public void onFileDelete(Path path) {
       log.error("onFileDelete failure: ", exc);
     }
   }
+
+  @Override
+  public void onCheckDetectedChange() {
+    try {
+      this.underlying.onCheckDetectedChange();
+    } catch (Throwable exc) {
+      log.error("onFileDelete failure: ", exc);
+    }

Review Comment:
   Oops good catch, will try to implement this
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 808473)
    Time Spent: 1h 20m  (was: 1h 10m)

> Build a file-based flowgraph that watches for changes and updates
> -----------------------------------------------------------------
>
>                 Key: GOBBLIN-1696
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1696
>             Project: Apache Gobblin
>          Issue Type: New Feature
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Gobblin-as-a-Service only has a Git based flowgraph, which is difficult to 
> build CI/CD around. We can provide an alternate flowgraph that is just based 
> off files. This flowgraph should update atomically.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to