[
https://issues.apache.org/jira/browse/GOBBLIN-1696?focusedWorklogId=810519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810519
]
ASF GitHub Bot logged work on GOBBLIN-1696:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/22 21:04
Start Date: 20/Sep/22 21:04
Worklog Time Spent: 10m
Work Description: AndyJiang99 commented on code in PR #3548:
URL: https://github.com/apache/gobblin/pull/3548#discussion_r975812541
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/GitFlowGraphMonitor.java:
##########
@@ -128,10 +131,11 @@ void processGitConfigChanges() throws GitAPIException,
IOException {
static class GitFlowgraphComparator implements Comparator<DiffEntry>,
Serializable {
public int compare(DiffEntry o1, DiffEntry o2) {
- Integer o1Depth = (o1.getNewPath() != null) ? (new
Path(o1.getNewPath())).depth() : (new Path(o1.getOldPath())).depth();
- Integer o2Depth = (o2.getNewPath() != null) ? (new
Path(o2.getNewPath())).depth() : (new Path(o2.getOldPath())).depth();
+ Integer o1Depth =
Review Comment:
Might be because I'm not too familiar with this, but could we change o1Depth
and o2Depth to be a bit more descriptive? Not too sure what o1 and o2 stand for
Issue Time Tracking
-------------------
Worklog Id: (was: 810519)
Time Spent: 3h (was: 2h 50m)
> Build a file-based flowgraph that watches for changes and updates
> -----------------------------------------------------------------
>
> Key: GOBBLIN-1696
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1696
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Gobblin-as-a-Service only has a Git based flowgraph, which is difficult to
> build CI/CD around. We can provide an alternate flowgraph that is just based
> off files. This flowgraph should update atomically.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
