[ 
https://issues.apache.org/jira/browse/GOBBLIN-1696?focusedWorklogId=808474&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-808474
 ]

ASF GitHub Bot logged work on GOBBLIN-1696:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/22 23:36
            Start Date: 13/Sep/22 23:36
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3548:
URL: https://github.com/apache/gobblin/pull/3548#discussion_r970168700


##########
gobblin-utility/src/main/java/org/apache/gobblin/util/filesystem/PathAlterationObserver.java:
##########
@@ -43,9 +43,9 @@ public class PathAlterationObserver {
   private final PathFilter pathFilter;
   private final Comparator<Path> comparator;
   private final FileSystem fs;
-
   private final Path[] EMPTY_PATH_ARRAY = new Path[0];
 
+  private boolean changeApplied = false;

Review Comment:
   I'll change the other functions to be synchronized as well, but I was under 
the impression it would be safe since those other functions are dependent on 
checkAndNotify, and since only 1 function execution can run at once, then the 
others shouldn't be able to modify the check at the same time?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 808474)
    Time Spent: 1.5h  (was: 1h 20m)

> Build a file-based flowgraph that watches for changes and updates
> -----------------------------------------------------------------
>
>                 Key: GOBBLIN-1696
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1696
>             Project: Apache Gobblin
>          Issue Type: New Feature
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Gobblin-as-a-Service only has a Git based flowgraph, which is difficult to 
> build CI/CD around. We can provide an alternate flowgraph that is just based 
> off files. This flowgraph should update atomically.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to