[
https://issues.apache.org/jira/browse/GOBBLIN-1697?focusedWorklogId=810211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810211
]
ASF GitHub Bot logged work on GOBBLIN-1697:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/22 00:32
Start Date: 20/Sep/22 00:32
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3549:
URL: https://github.com/apache/gobblin/pull/3549#discussion_r974787645
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/SpecStore.java:
##########
@@ -78,6 +78,16 @@ public interface SpecStore {
*/
Spec updateSpec(Spec spec) throws IOException, SpecNotFoundException;
+ /***
+ * Update {@link Spec} in the {@link SpecStore} when current version is
smaller than {@link version}.
+ * @param spec {@link Spec} to be updated.
+ * @param version largest version that current spec should be
+ * @throws IOException Exception in updating the {@link Spec}.
+ * @return Updated {@link Spec}.
+ * @throws SpecNotFoundException If {@link Spec} being updated is not
present in store.
+ */
+ default Spec updateSpec(Spec spec, long version) throws IOException,
SpecNotFoundException {return updateSpec(spec);};
Review Comment:
So this comment is on the outdated code, so it may not be applicable. Are we
trying to change our code to handle two concurrent requests? I think we can
achieve this with the right mysql commands only.
Issue Time Tracking
-------------------
Worklog Id: (was: 810211)
Time Spent: 1h 50m (was: 1h 40m)
> Have a separate resource handler to rely on CDC stream to do message
> forwarding
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1697
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1697
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
