[
https://issues.apache.org/jira/browse/GOBBLIN-1697?focusedWorklogId=810215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810215
]
ASF GitHub Bot logged work on GOBBLIN-1697:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/22 00:46
Start Date: 20/Sep/22 00:46
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3549:
URL: https://github.com/apache/gobblin/pull/3549#discussion_r974792579
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java:
##########
@@ -161,10 +161,14 @@ public CreateResponse createFlowConfig(FlowConfig
flowConfig) throws FlowConfigL
return this.createFlowConfig(flowConfig, true);
}
+ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig,
boolean triggerListener) {
+ // Set the max version to be the largest value so that we blindly update
the flow spec in this case
+ return updateFlowConfig(flowId, flowConfig, triggerListener,
Long.MAX_VALUE);
+ }
/**
* Update flowConfig locally and trigger all listeners iff @param
triggerListener is set to true
*/
- public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig,
boolean triggerListener) {
+ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig,
boolean triggerListener, long modifiedWatermark) {
Review Comment:
Same thing in this PR, just update the name to avoid confusion. Basically we
will not update the entry if the modification time is larger than the
"modifiedWatermark" / "version"
Issue Time Tracking
-------------------
Worklog Id: (was: 810215)
Time Spent: 2h 20m (was: 2h 10m)
> Have a separate resource handler to rely on CDC stream to do message
> forwarding
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1697
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1697
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
