[
https://issues.apache.org/jira/browse/GOBBLIN-1696?focusedWorklogId=812020&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812020
]
ASF GitHub Bot logged work on GOBBLIN-1696:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/22 08:13
Start Date: 26/Sep/22 08:13
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3548:
URL: https://github.com/apache/gobblin/pull/3548#discussion_r979700601
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/GitFlowGraphListener.java:
##########
@@ -53,10 +47,10 @@ public GitFlowGraphListener(Optional<? extends
FSFlowTemplateCatalog> flowTempla
@Override
public void addChange(DiffEntry change) {
Path path = new Path(change.getNewPath());
- if (path.depth() == NODE_FILE_DEPTH) {
- addDataNode(change.getNewPath());
- } else if (path.depth() == EDGE_FILE_DEPTH) {
- addFlowEdge(change.getNewPath());
+ if (path.depth() == BaseFlowGraphHelper.NODE_FILE_DEPTH) {
+ this.baseFlowGraphHelper.addDataNode(this.flowGraph.get(),
change.getNewPath());
Review Comment:
Nevermind I just went with making the gitflowgraphmonitor also update once
per detected change in Git, seems like the more sensical solution given the
complexity with the other approaches.
Issue Time Tracking
-------------------
Worklog Id: (was: 812020)
Time Spent: 4h 50m (was: 4h 40m)
> Build a file-based flowgraph that watches for changes and updates
> -----------------------------------------------------------------
>
> Key: GOBBLIN-1696
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1696
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Gobblin-as-a-Service only has a Git based flowgraph, which is difficult to
> build CI/CD around. We can provide an alternate flowgraph that is just based
> off files. This flowgraph should update atomically.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
