[ 
https://issues.apache.org/jira/browse/GOBBLIN-1696?focusedWorklogId=811997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811997
 ]

ASF GitHub Bot logged work on GOBBLIN-1696:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Sep/22 05:54
            Start Date: 26/Sep/22 05:54
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3548:
URL: https://github.com/apache/gobblin/pull/3548#discussion_r979582884


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompiler.java:
##########
@@ -168,7 +171,7 @@ public MultiHopFlowCompiler(Config config, Optional<Logger> 
log, boolean instrum
   }
 
   @VisibleForTesting
-  MultiHopFlowCompiler(Config config, FlowGraph flowGraph) {
+  MultiHopFlowCompiler(Config config, AtomicReference<FlowGraph> flowGraph) {

Review Comment:
   This is needed for testing, not sure how to be able to test the flow 
compiler otherwise without a getter.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 811997)
    Time Spent: 4.5h  (was: 4h 20m)

> Build a file-based flowgraph that watches for changes and updates
> -----------------------------------------------------------------
>
>                 Key: GOBBLIN-1696
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1696
>             Project: Apache Gobblin
>          Issue Type: New Feature
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> Gobblin-as-a-Service only has a Git based flowgraph, which is difficult to 
> build CI/CD around. We can provide an alternate flowgraph that is just based 
> off files. This flowgraph should update atomically.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to