[
https://issues.apache.org/jira/browse/GOBBLIN-1696?focusedWorklogId=812292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812292
]
ASF GitHub Bot logged work on GOBBLIN-1696:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/22 23:03
Start Date: 26/Sep/22 23:03
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3548:
URL: https://github.com/apache/gobblin/pull/3548#discussion_r980554915
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/filesystem/PathAlterationObserver.java:
##########
@@ -187,6 +189,13 @@ public void checkAndNotify()
for (final PathAlterationListener listener : listeners.values()) {
listener.onStop(this);
}
+
+ if (this.changeApplied) {
Review Comment:
Should this be added before the onStop method is called?
Issue Time Tracking
-------------------
Worklog Id: (was: 812292)
Time Spent: 5h (was: 4h 50m)
> Build a file-based flowgraph that watches for changes and updates
> -----------------------------------------------------------------
>
> Key: GOBBLIN-1696
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1696
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Gobblin-as-a-Service only has a Git based flowgraph, which is difficult to
> build CI/CD around. We can provide an alternate flowgraph that is just based
> off files. This flowgraph should update atomically.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
