[
https://issues.apache.org/jira/browse/GOBBLIN-1774?focusedWorklogId=843949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843949
]
ASF GitHub Bot logged work on GOBBLIN-1774:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/23 21:28
Start Date: 06/Feb/23 21:28
Worklog Time Spent: 10m
Work Description: vikrambohra commented on code in PR #3632:
URL: https://github.com/apache/gobblin/pull/3632#discussion_r1097936139
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java:
##########
@@ -256,6 +256,23 @@ public static SerDeInfo getSerDeInfo(HiveRegistrationUnit
unit) {
return si;
}
+ /**
+ * Util for detecting if a table has a complex union (aka non-optional
unions) column types. Iceberg currently does
+ * not natively support uniontype because types differently as structs.
Until this feature is added in iceberg, this
+ * function can be used to detect these types of tables for gobblin specific
workarounds
+ *
+ * See https://github.com/apache/iceberg/issues/189
+ *
+ * @param t
+ * @return if hive table contains complex uniontype columns
+ */
+ public static boolean containsUnionTypeColumn(HiveTable t) {
Review Comment:
Can we have another method that takes Hive native table object instead of
Gobblin Hive Table wrapper object and one calling the other?
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java:
##########
@@ -256,6 +256,23 @@ public static SerDeInfo getSerDeInfo(HiveRegistrationUnit
unit) {
return si;
}
+ /**
+ * Util for detecting if a table has a complex union (aka non-optional
unions) column types. Iceberg currently does
Review Comment:
This is a simple utility method to tell if a hive table contains a complex
union. Lets not complicate my mentioning iceberg.
Issue Time Tracking
-------------------
Worklog Id: (was: 843949)
Time Spent: 1h (was: 50m)
> Add utility method for GMIP, MR compaction, and Incremental to skip override
> hive schema on topics with complex union
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1774
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1774
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
