[
https://issues.apache.org/jira/browse/GOBBLIN-1774?focusedWorklogId=844467&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844467
]
ASF GitHub Bot logged work on GOBBLIN-1774:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/23 21:50
Start Date: 08/Feb/23 21:50
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3632:
URL: https://github.com/apache/gobblin/pull/3632#discussion_r1100717050
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java:
##########
@@ -256,6 +255,23 @@ public static SerDeInfo getSerDeInfo(HiveRegistrationUnit
unit) {
return si;
}
+ /**
+ * Util for detecting if a table has a complex union (aka non-optional
unions) column types.
+ *
+ * @param t
+ * @return if hive table contains complex uniontype columns
+ */
+ public static boolean containsUnionTypeColumn(HiveTable t) {
+ return t.getColumns().stream()
+ .map(HiveRegistrationUnit.Column::getType)
+ .map(Object::toString)
+ .anyMatch(columnType -> columnType.contains("uniontype"));
Review Comment:
Seems to me we only check union type but not non-optional union type. Is
this intentional? If so, please update the description to reflect that as well.
Issue Time Tracking
-------------------
Worklog Id: (was: 844467)
Time Spent: 1h 20m (was: 1h 10m)
> Add utility method for GMIP, MR compaction, and Incremental to skip override
> hive schema on topics with complex union
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1774
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1774
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
