[ 
https://issues.apache.org/jira/browse/GOBBLIN-1774?focusedWorklogId=844184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844184
 ]

ASF GitHub Bot logged work on GOBBLIN-1774:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Feb/23 21:21
            Start Date: 07/Feb/23 21:21
    Worklog Time Spent: 10m 
      Work Description: vikrambohra commented on code in PR #3632:
URL: https://github.com/apache/gobblin/pull/3632#discussion_r1099258661


##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java:
##########
@@ -257,11 +256,7 @@ public static SerDeInfo getSerDeInfo(HiveRegistrationUnit 
unit) {
   }
 
   /**
-   * Util for detecting if a table has a complex union (aka non-optional 
unions) column types. Iceberg currently does
-   * not natively support uniontype because types differently as structs. 
Until this feature is added in iceberg, this
-   * function can be used to detect these types of tables for gobblin specific 
workarounds
-   *
-   * See https://github.com/apache/iceberg/issues/189
+   * Util for detecting if a table has a complex union (aka non-optional 
unions) column types.
    *
    * @param t

Review Comment:
   Nit: Hive table t





Issue Time Tracking
-------------------

    Worklog Id:     (was: 844184)
    Time Spent: 1h 10m  (was: 1h)

> Add utility method for GMIP, MR compaction, and Incremental to skip override 
> hive schema on topics with complex union
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1774
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1774
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to