AndyJiang99 commented on code in PR #3640:
URL: https://github.com/apache/gobblin/pull/3640#discussion_r1103146215
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlBaseSpecStore.java:
##########
@@ -84,6 +84,7 @@ public class MysqlBaseSpecStore extends InstrumentedSpecStore
{
private static final String GET_ALL_STATEMENT = "SELECT spec_uri, spec FROM
%s";
private static final String GET_ALL_URIS_STATEMENT = "SELECT spec_uri FROM
%s";
private static final String GET_ALL_URIS_WITH_TAG_STATEMENT = "SELECT
spec_uri FROM %s WHERE tag = ?";
+ private static final String GET_SPECS_BATCH_STATEMENT = "SELECT spec_uri,
spec FROM %s ORDER BY spec_uri ASC LIMIT ? OFFSET ?";
Review Comment:
It's possible that we can have two specs with the same spec_uri I believe.
We should keep the modified_time ordering part of the statement too so if there
are two specs with the same spec_uri so the ordering of the result from the
same query stays the same at all times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
